Split gd_color.c[ch] (sync with upstream)#17324
Open
cmb69 wants to merge 1 commit into
Open
Conversation
Member
|
My guess is that floating point division is one order of magnitude slower than multiplication: http://ithare.com/infographics-operation-costs-in-cpu-clock-cycles/ |
Member
Author
|
Ah, thank you @Girgias, I wasn't aware of that (and misunderstood the commit message). |
Girgias
reviewed
Mar 31, 2025
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Have there been changes to upstream again or not? Otherwise I think this is good to land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea why this has diverged in the first place. Upstream introduced gd_color.[ch] already in 2008, while we have cropping support only since 2013. Anyhow, syncing with upstream now is better than never.
The code is the same, except for libgd/libgd@d500229, what I don't understand, since there has been no int division in the first place due to usual arithmetic conversions, but at least there is not even a minor BC break. (Also note that this calculation doesn't make much sense, see libgd/libgd#334).
One caveat, though: gd_color.h is now exported (see #16070; need to work on that).